From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Honig <ahonig@google.com>, Michal Marek <mmarek@suse.cz>,
"x86@kernel.org" <x86@kernel.org>, Tejun Heo <tj@kernel.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] kallsyms: handle special absolute symbols
Date: Mon, 10 Mar 2014 20:02:24 +0000 [thread overview]
Message-ID: <20140310130224.70ec6a1940ec636bfb89f6bb@linux-foundation.org> (raw)
In-Reply-To: <CAGXu5j+9Qt2p+dqdqcecMQ4RRb8tBVMqMDBdRGFjiRQHmDaatQ@mail.gmail.com>
On Mon, 10 Mar 2014 12:58:06 -0700 Kees Cook <keescook@chromium.org> wrote:
> On Mon, Mar 10, 2014 at 12:06 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Fri, 7 Mar 2014 17:00:23 -0800 Kees Cook <keescook@chromium.org> wrote:
> >> Handles 0-based per_cpu variables as being absolute so they are
> >> not relocated under kASLR on x86_64.
> >
> > Would it be prudent to revert 0f55159d091cb1e5 ("kallsyms: fix absolute
> > addresses for kASLR") then sort all this out for 3.15?
>
> My opinion is that if it breaks a real-life case (avr32), it should be
> reverted.
We aren't going to be able to test this on 40 architectures so yes,
let's take the cautious approach.
> The only people affected by the kallsyms per_cpu relocation
> reporting bug are those using kASLR on x86, and even then the bug is a
> corner case on live kernel debugging.
>
> I am fine either way.
prev parent reply other threads:[~2014-03-10 20:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 1:00 [PATCH v2 0/2] kallsyms: handle special absolute symbols Kees Cook
2014-03-08 1:00 ` [PATCH v2 1/2] kallsyms: generalize address range checking Kees Cook
2014-03-08 1:00 ` [PATCH v2 2/2] kallsyms: handle special absolute symbols Kees Cook
2014-03-11 21:03 ` Kees Cook
2014-03-13 0:42 ` Rusty Russell
2014-03-13 0:40 ` Kees Cook
2014-03-13 3:52 ` Rusty Russell
2014-03-13 6:23 ` Kees Cook
2014-03-17 3:48 ` Rusty Russell
2014-03-10 19:06 ` [PATCH v2 0/2] " Andrew Morton
2014-03-10 19:58 ` Kees Cook
2014-03-10 20:02 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310130224.70ec6a1940ec636bfb89f6bb@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ahonig@google.com \
--cc=fenghua.yu@intel.com \
--cc=keescook@chromium.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox