From: Fengguang Wu <fengguang.wu@intel.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [staging:staging-next 151/175] drivers/staging/comedi/drivers/ni_pcimio.c:1105:42: error: macro
Date: Thu, 19 Jun 2014 01:14:00 +0000 [thread overview]
Message-ID: <20140619011400.GB31778@localhost> (raw)
On Wed, Jun 18, 2014 at 11:13:13PM +0000, Hartley Sweeten wrote:
> On Wednesday, June 18, 2014 3:44 PM, kbuild test robot wrote:
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
> > head: 98e11370052aa88a38c2d5d1693a5ec2966c4f81
> > commit: 9c340ac934dbbfd46e776465b08391baac32d486 [151/175] staging: comedi: ni_stc.h: add read/write callbacks to struct ni_private
> > config: make ARCH=ia64 allmodconfig
> >
> > All error/warnings:
> >
> > drivers/staging/comedi/drivers/ni_pcimio.c: In function 'e_series_win_out':
> > >> drivers/staging/comedi/drivers/ni_pcimio.c:1105:42: error: macro "writew" passed 3 arguments, but takes just 2
> > drivers/staging/comedi/drivers/ni_pcimio.c:1105:2: warning: statement with no effect [-Wunused-value]
>
> [snip]
>
> > vim +/writew +1105 drivers/staging/comedi/drivers/ni_pcimio.c
> >
> > 1099 static void e_series_win_out(struct comedi_device *dev, uint16_t data, int reg)
> > 1100 {
> > 1101 struct ni_private *devpriv = dev->private;
> > 1102 unsigned long flags;
> > 1103
> > 1104 spin_lock_irqsave(&devpriv->window_lock, flags);
> > > 1105 devpriv->writew(dev, reg, Window_Address);
>
> I don't get it... Why is the 'writew' above being treated as a macro in your build?
wfg /c/linux% grep -r writew arch/ia64
arch/ia64/lib/io.c:#undef __ia64_writew
arch/ia64/include/asm/io.h:#define __ia64_writew ___ia64_writew
arch/ia64/include/asm/io.h:__writew (unsigned short val, volatile void __iomem *addr)
=> arch/ia64/include/asm/io.h:#define writew(v,a) __writew((v), (a))
arch/ia64/include/asm/io.h:#define __raw_writew writew
> I'm not seeing these errors in my build with the x86_64_defconfig.
Hartley, it's an error in ARCH=ia64 builds.
Thanks,
Fengguang
> I have some patches that get rid of these callbacks that I was holding until Greg
> got his staging tree caught up. I can post those, which should make this build
> error go away, but I'm not sure why it is happening on ia64.
>
> Regards,
> Hartley
next reply other threads:[~2014-06-19 1:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 1:14 Fengguang Wu [this message]
2014-06-19 17:01 ` [staging:staging-next 151/175] drivers/staging/comedi/drivers/ni_pcimio.c:1105:42: error: macro Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619011400.GB31778@localhost \
--to=fengguang.wu@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox