From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Date: Fri, 07 Aug 2015 09:05:53 +0000 Subject: Re: [BUG]: Intel uncore boot warning introduced in 4.1 Message-Id: <20150807090553.GC16853@twins.programming.kicks-ass.net> List-Id: References: <1438853676.3139.20.camel@mattleach.net> <87bneko0o5.fsf@mattleach.net> <37D7C6CF3E00A74B8858931C1DB2F077018D32C2@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077018D32C2@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Liang, Kan" Cc: Matthew Leach , Ingo Molnar , "linux-kernel@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "eranian@google.com" , 'Andi Kleen' , 'Bjorn Helgaas' , 'Vince Weaver' , 'Sonny Rao' On Thu, Aug 06, 2015 at 06:10:40PM +0000, Liang, Kan wrote: > The issue may be caused by uncore box initialization. > > For preventing the potential issues of uncore box initialization, I once > moved the uncore_box_init() out of driver initialization in commit > c05199e5a57a579fea1e8fa65e2b511ceb524ffc. > > However, it cause some desktop crash, because the box initialization > codes were moved in IPI context. > > For fixing the crash issue, we had two choice at that time. > - Simply revert the codes. That's where is > 15c1247953e8a45232ed5a5540f291d2d0a77665 from. > - Move uncore_box_init out of IPI context to uncore event > init. I provided a patch for it. https://lkml.org/lkml/2015/4/28/21 > Stephane Eranian also verified it on his platform > > At that time, we chose first option. But it looks there is some > issue now. I guess we may try the second option this time. > > Matthew, > > Could you please revert > 15c1247953e8a45232ed5a5540f291d2d0a77665 > and apply the patch https://lkml.org/lkml/2015/4/26/294? > See if it works? That patch is wrong though; how can even publish a PMU which is not initialized?