From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Date: Sat, 14 Jan 2017 16:29:15 +0000 Subject: Re: [RFC PATCH 3/4] arch, mm: remove arch specific show_mem Message-Id: <20170114162915.GF26139@cmpxchg.org> List-Id: References: <20170112131659.23058-1-mhocko@kernel.org> <20170112131659.23058-4-mhocko@kernel.org> In-Reply-To: <20170112131659.23058-4-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , David Rientjes , Michal Hocko , Tony Luck , Fenghua Yu , "James E.J. Bottomley" , Helge Deller , "David S. Miller" , Chris Metcalf , Guan Xuetao , linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org On Thu, Jan 12, 2017 at 02:16:58PM +0100, Michal Hocko wrote: > From: Michal Hocko > > We have a generic implementation for quite some time already. If there > is any arch specific information to be printed then we should add a > callback called from the generic code rather than duplicate the whole > show_mem. The current code has resulted in the code duplication and > the output divergence which is both confusing and adds maintainance > costs. Let's just get rid of this mess. > > Cc: Tony Luck > Cc: Fenghua Yu > Cc: "James E.J. Bottomley" > Cc: Helge Deller > Cc: "David S. Miller" > Cc: Chris Metcalf > Cc: Guan Xuetao > Cc: linux-ia64@vger.kernel.org > Cc: linux-parisc@vger.kernel.org > Signed-off-by: Michal Hocko Acked-by: Johannes Weiner