From: Bjorn Helgaas <helgaas@kernel.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, hch@infradead.org,
Arnd Bergmann <arnd@arndb.de>,
linux-snps-arc@lists.infradead.org, linux-cris-kernel@axis.com,
linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: pci: Add generic pcibios_{fixup_bus,align_resource}
Date: Wed, 02 Aug 2017 20:00:31 +0000 [thread overview]
Message-ID: <20170802200031.GD20308@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20170624015044.16746-1-palmer@dabbelt.com>
On Fri, Jun 23, 2017 at 06:50:41PM -0700, Palmer Dabbelt wrote:
> While upstreaming the RISC-V port, it was pointed out that multiple
> architectures have copied the mostly empty versions of at least one of these
> functions. This defines weakly bound versions of the common functions and
> removes the now obselete functions from other ports.
>
> This has been split out from the RISC-V submission so we can decouple all these
> generic changes from our port review process. There's some discussion on an
> earlier version of the patch here
>
> https://lkml.org/lkml/2017/6/6/998
>
> but I'm afraid a lot of this is really out of my wheelhouse (and I'm pretty
> slammed trying to get the RISC-V port in better shape), so I'm afraid I'm not
> going to be able to perform the full cleanup suggested.
Applied to pci/resource for v4.14, thanks!
There's room for future improvement, e.g., using per-host callbacks,
etc., but I think this is a clear improvement as-is.
There's some folklore about the evils of weak symbols, but I don't
know the details. It would be useful to have them codified somewhere
in Documentation/ or near the __weak definition.
prev parent reply other threads:[~2017-08-02 20:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 1:50 pci: Add generic pcibios_{fixup_bus,align_resource} Palmer Dabbelt
2017-06-24 1:50 ` [PATCH 1/3] pci: Add a generic, weakly-linked pcibios_fixup_bus Palmer Dabbelt
2017-06-24 9:34 ` Geert Uytterhoeven
2017-06-24 21:32 ` Palmer Dabbelt
2017-06-24 1:50 ` [PATCH 2/3] pci: Add a generic, weakly-linked pcibios_align_resource Palmer Dabbelt
2017-06-24 9:41 ` Geert Uytterhoeven
2017-06-24 21:32 ` Palmer Dabbelt
2017-06-24 1:50 ` [PATCH 3/3] arc: kernel/pcibios.c is empty, delete it Palmer Dabbelt
2017-08-02 20:00 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802200031.GD20308@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox