From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Villemoes Date: Thu, 01 Mar 2018 23:37:21 +0000 Subject: [RFC 2/5] ia64/sn/hwperf: use seq_open_data Message-Id: <20180301233724.20440-2-linux@rasmusvillemoes.dk> List-Id: References: <20180301233724.20440-1-linux@rasmusvillemoes.dk> In-Reply-To: <20180301233724.20440-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tony Luck , Fenghua Yu Cc: Rasmus Villemoes , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org This code should check the return value of seq_open(); if it failed, file->private_data is NULL. But we can avoid the issue entirely and simplify the code by letting seq_open_data() set the ->private member to objbuf. Signed-off-by: Rasmus Villemoes --- arch/ia64/sn/kernel/sn2/sn_hwperf.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/ia64/sn/kernel/sn2/sn_hwperf.c b/arch/ia64/sn/kernel/sn2/sn_hwperf.c index 55febd65911a..fba7f3ad99f4 100644 --- a/arch/ia64/sn/kernel/sn2/sn_hwperf.c +++ b/arch/ia64/sn/kernel/sn2/sn_hwperf.c @@ -941,14 +941,11 @@ static int sn_hwperf_init(void) int sn_topology_open(struct inode *inode, struct file *file) { int e; - struct seq_file *seq; struct sn_hwperf_object_info *objbuf; int nobj; if ((e = sn_hwperf_enum_objects(&nobj, &objbuf)) = 0) { - e = seq_open(file, &sn_topology_seq_ops); - seq = file->private_data; - seq->private = objbuf; + e = seq_open_data(file, &sn_topology_seq_ops, objbuf); } return e; -- 2.15.1