From: Will Deacon <will.deacon@arm.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] [SUBMITTED 20180724] arm64: fix ACPI dependencies
Date: Tue, 24 Jul 2018 15:14:37 +0000 [thread overview]
Message-ID: <20180724151435.GB25412@arm.com> (raw)
In-Reply-To: <CAJZ5v0h1zGHrMo6HLtSMWE4kM9YK-3QvgHnBaRrEpMHAJrrMtg@mail.gmail.com>
On Tue, Jul 24, 2018 at 12:23:48PM +0200, Rafael J. Wysocki wrote:
> On Tue, Jul 24, 2018 at 12:21 PM, Will Deacon <will.deacon@arm.com> wrote:
> > On Tue, Jul 24, 2018 at 11:54:25AM +0200, Rafael J. Wysocki wrote:
> >> On Tue, Jul 24, 2018 at 11:48 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> >> > Kconfig reports a warning on x86 builds after the ARM64 dependency
> >> > was added.
> >> >
> >> > drivers/acpi/Kconfig:6:error: recursive dependency detected!
> >> > drivers/acpi/Kconfig:6: symbol ACPI depends on EFI
> >> >
> >> > This rephrases the dependency to keep the ARM64 details out of the
> >> > shared Kconfig file, so Kconfig no longer gets confused by it.
> >> >
> >> > For consistency, all three architectures that support ACPI now
> >> > select ARCH_SUPPORTS_ACPI in exactly the configuration in which
> >> > they allow it. We still need the 'default x86', as each one
> >> > wants a different default: default-y on x86, default-n on arm64,
> >> > and always-y on ia64.
> >> >
> >> > Fixes: 5bcd44083a08 ("drivers: acpi: add dependency of EFI for arm64")
> >> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> > ---
> >> > v2: use 'select ARCH_SUPPORTS_ACPI' for all three.
> >>
> >> LGTM
> >>
> >> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Same here:
> >
> > Acked-by: Will Deacon <will.deacon@arm.com>
> >
> > Would it be ok if I take this via the arm64 tree, since that's where the
> > warning was introduced?
>
> Yes, it would, from the ACPI side.
Ok, I'll stick this into next tomorrow pending any objections from the x86
maintainers.
Will
prev parent reply other threads:[~2018-07-24 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 9:48 [PATCH] [SUBMITTED 20180724] arm64: fix ACPI dependencies Arnd Bergmann
2018-07-24 9:54 ` Rafael J. Wysocki
2018-07-24 10:21 ` Will Deacon
2018-07-24 10:23 ` Rafael J. Wysocki
2018-07-24 15:14 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724151435.GB25412@arm.com \
--to=will.deacon@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=takahiro.akashi@linaro.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox