From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Date: Fri, 27 Jul 2018 05:31:37 +0000 Subject: Re: [PATCH 1/2] ia64: use asm-generic/io.h Message-Id: <20180727073137.58668bf2@bbrezillon> List-Id: References: <20180711120824.3882108-1-arnd@arndb.de> In-Reply-To: <20180711120824.3882108-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org Hi Arnd, On Wed, 11 Jul 2018 14:08:05 +0200 Arnd Bergmann wrote: > asm-generic/io.h provides a generic implementation of all I/O accessors, > which the architectures can override. > > Since ia64 does not provide readsl/writesl etc, any driver using those > fails to build, and including asm-generic/io.h will provide the > missing interfaces, as well as any other future interfaces that get > added there. We need to #define a couple of symbols to themselves > in the ia64 to ensure that we use the ia64 specific version of those > rather than the generic one. > > There should be no other effect than adding {read,write}s{b,w,l}() > as well as {in,out}s{b,w,l}_p(), which were also not provided > by ia64 but are provided by the generic header for historic reasons. > Kbuild robots reported the same problem on parisc an alpha :-/. Regards, Boris