Re: [RFC PATCH 07/29] memblock: remove _virt from APIs returning virtual address

Michal Hocko
2018-09-06T07:28:00Z

On Wed 05-09-18 20:20:18, Mike Rapoport wrote:
> On Wed, Sep 05, 2018 at 12:04:36PM -0500, Rob Herring wrote:
> > On Wed, Sep 5, 2018 at 11:00 AM Mike Rapoport <rppt@linux.vnet.ibm.com> wrote:
> > >
> > > The conversion is done using
> > >
> > > sed -i 's@memblock_virt_alloc@memblock_alloc@g' \
> > > $(git grep -l memblock_virt_alloc)
> >
> > What's the reason to do this? It seems like a lot of churn even if a
> > mechanical change.
>
> I felt that memblock_virt_alloc_ is too long for a prefix, e.g:
> memblock_virt_alloc_node_nopanic, memblock_virt_alloc_low_nopanic.
>
> And for consistency I've changed the memblock_virt_alloc as well.

I would keep the current API unless the name is terribly misleading or
it can be improved a lot. Neither seems to be the case here. So I would
rather stick with the status quo.
--
Michal Hocko
SUSE Labs