From: Tony Luck <tony.luck@intel.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH: Linus please apply] ia64: Make sure that we have a mmiowb function real early
Date: Thu, 16 May 2019 01:04:14 +0000 [thread overview]
Message-ID: <20190516010414.30623-1-tony.luck@intel.com> (raw)
Generic kernels feed many operation through the "machvec"
logic to get the correct form of the operation for the
current system. "mmiowb()" is one of those operations.
Although machvec is initialized very early in boot, it isn't
early enough for a recent upstream kernel change that added
mmiowb to the spin_unlock() path.
Statically initialize the mmiowb field of machvec so that we
won't die with a call through a NULL pointer. This should be
safe because we do the real initialization of machvec before
bringing up any addtional CPUs or doing any I/O.
Fixes: 49ca6462fc9e ("ia64/mmiowb: Add unconditional mmiowb() to arch_spin_unlock()")
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
arch/ia64/kernel/machvec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/ia64/kernel/machvec.c b/arch/ia64/kernel/machvec.c
index 1b604d02250b..ebd82535f51b 100644
--- a/arch/ia64/kernel/machvec.c
+++ b/arch/ia64/kernel/machvec.c
@@ -10,7 +10,9 @@
#include <asm/page.h>
-struct ia64_machine_vector ia64_mv;
+struct ia64_machine_vector ia64_mv = {
+ .mmiowb = ___ia64_mmiowb
+};
EXPORT_SYMBOL(ia64_mv);
static struct ia64_machine_vector * __init
--
2.20.1
next reply other threads:[~2019-05-16 1:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 1:04 Tony Luck [this message]
2019-05-16 1:44 ` [PATCH: Linus please apply] ia64: Make sure that we have a mmiowb function real early Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516010414.30623-1-tony.luck@intel.com \
--to=tony.luck@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox