From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Date: Tue, 24 Sep 2019 12:31:47 +0000 Subject: Re: [PATCH V3 0/2] mm/debug: Add tests for architecture exported page table helpers Message-Id: <20190924123146.GC5202@linux.ibm.com> List-Id: References: <1568961203-18660-1-git-send-email-anshuman.khandual@arm.com> <20190924115101.p6y7vpbtgmj5qjku@box> In-Reply-To: <20190924115101.p6y7vpbtgmj5qjku@box> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Kirill A. Shutemov" Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Tetsuo Handa , Heiko Carstens , Michal Hocko , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Jason Gunthorpe , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Anshuman Khandual , Masahiro Yamada , Mark Brown , Dan Williams , Vlastimil Babka , Christophe Leroy , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , Dave Hansen , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Mike Kravetz On Tue, Sep 24, 2019 at 02:51:01PM +0300, Kirill A. Shutemov wrote: > On Fri, Sep 20, 2019 at 12:03:21PM +0530, Anshuman Khandual wrote: > > This series adds a test validation for architecture exported page table > > helpers. Patch in the series adds basic transformation tests at various > > levels of the page table. Before that it exports gigantic page allocation > > function from HugeTLB. > > > > This test was originally suggested by Catalin during arm64 THP migration > > RFC discussion earlier. Going forward it can include more specific tests > > with respect to various generic MM functions like THP, HugeTLB etc and > > platform specific tests. > > > > https://lore.kernel.org/linux-mm/20190628102003.GA56463@arrakis.emea.arm.com/ > > > > Testing: > > > > Successfully build and boot tested on both arm64 and x86 platforms without > > any test failing. Only build tested on some other platforms. Build failed > > on some platforms (known) in pud_clear_tests() as there were no available > > __pgd() definitions. > > > > - ARM32 > > - IA64 > > Hm. Grep shows __pgd() definitions for both of them. Is it for specific > config? For ARM32 it's defined only for 3-lelel page tables, i.e with LPAE on. For IA64 it's defined for !STRICT_MM_TYPECHECKS which is even not a config option, but a define in arch/ia64/include/asm/page.h > -- > Kirill A. Shutemov -- Sincerely yours, Mike.