Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA

Kees Cook
2019-11-12T20:55:09Z

On Mon, Nov 11, 2019 at 07:08:51PM +0100, Geert Uytterhoeven wrote:
> Hi Kees,
>
> On Mon, Nov 11, 2019 at 6:23 PM Kees Cook <keescook@chromium.org> wrote:
> > On Mon, Nov 11, 2019 at 05:58:06PM +0100, Geert Uytterhoeven wrote:
> > > On Fri, Oct 11, 2019 at 2:07 AM Kees Cook <keescook@chromium.org> wrote:
> > > > There's no reason to keep the RODATA macro: replace the callers with
> > > > the expected RO_DATA macro.
> > > >
> > > > Signed-off-by: Kees Cook <keescook@chromium.org>
> > > > ---
> > > > arch/alpha/kernel/vmlinux.lds.S | 2 +-
> > > > arch/ia64/kernel/vmlinux.lds.S | 2 +-
> > > > arch/microblaze/kernel/vmlinux.lds.S | 2 +-
> > > > arch/mips/kernel/vmlinux.lds.S | 2 +-
> > > > arch/um/include/asm/common.lds.S | 2 +-
> > > > arch/xtensa/kernel/vmlinux.lds.S | 2 +-
> > > > include/asm-generic/vmlinux.lds.h | 4 +---
> > > > 7 files changed, 7 insertions(+), 9 deletions(-)
> > >
> > > Somehow you missed:
> > >
> > > arch/m68k/kernel/vmlinux-std.lds: RODATA
> > > arch/m68k/kernel/vmlinux-sun3.lds: RODATA
> >
> > Argh. I've sent a patch; sorry and thanks for catching this. For my own
> > cross-build testing, which defconfig targets will hit these two linker
> > scripts?
>
> vmlinux-sun3.lds: sun3_defconfig
> vmlinux-std.lds: All other classic 680x0 targets with an MMU, e.g. plain
> defconfig aka multi_defconfig.

Excellent, thank you; I've updated my multi-arch build list. :)

--
Kees Cook