From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Date: Wed, 23 Oct 2019 23:20:04 +0000 Subject: Re: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver Message-Id: <20191023232004.GV3125@piout.net> List-Id: References: <20191023150311.844123-1-arnd@arndb.de> <20191023184616.GA17078@agluck-desk2.amr.corp.intel.com> <20191023200135.GT3125@piout.net> <3908561D78D1C84285E8C5FCA982C28F7F4AD7F7@ORSMSX115.amr.corp.intel.com> In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7F4AD7F7@ORSMSX115.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Luck, Tony" Cc: Arnd Bergmann , Greg Kroah-Hartman , "linux-rtc@vger.kernel.org" , Alessandro Zummo , "linux-ia64@vger.kernel.org" , "Yu, Fenghua" , Stephane Eranian , "linux-kernel@vger.kernel.org" On 23/10/2019 21:30:29+0000, Luck, Tony wrote: > >> rtc-efi rtc-efi: setting system clock to 2019-10-23T18:30:23 UTC (1571855423) > > > You can remove CONFIG_RTC_HCTOSYS, this line will disappear, systemd > > will not like that but efirtc was not setting the system time anyway so > > this shouldn't change the behaviour. > > > Wait ... that message says "setting system clock" > > but then you say " efirtc was not setting the system time anyway". > > So did the time get set, or not? > > If it wasn't set, why does the message say that it was set? > What I meant was that drivers/char/efirtc.c was not setting the system time but when using drivers/rtc/rtc-efi.c with CONFIG_RTC_HCTOSYS, the kernel will use the rtc to set the system time. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com