From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rich Felker Date: Mon, 20 Jul 2020 21:39:13 +0000 Subject: Re: [PATCH v3 3/6] sh/mm: use default dummy memory_add_physaddr_to_nid() Message-Id: <20200720213913.GM14669@brightrain.aerifal.cx> List-Id: References: <20200709020629.91671-1-justin.he@arm.com> <20200709020629.91671-4-justin.he@arm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Hildenbrand Cc: Jia He , Catalin Marinas , Will Deacon , Tony Luck , Fenghua Yu , Yoshinori Sato , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , Baoquan He , Chuhong Yuan , Mike Rapoport , Masahiro Yamada , Michal Hocko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org, Jonathan Cameron , Kaly Xin On Thu, Jul 09, 2020 at 11:10:36AM +0200, David Hildenbrand wrote: > On 09.07.20 04:06, Jia He wrote: > > After making default memory_add_physaddr_to_nid in mm/memory_hotplug, > > there is no use to define a similar one in arch specific directory. > > > > Signed-off-by: Jia He > > --- > > arch/sh/mm/init.c | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > > index a70ba0fdd0b3..f75932ba87a6 100644 > > --- a/arch/sh/mm/init.c > > +++ b/arch/sh/mm/init.c > > @@ -430,15 +430,6 @@ int arch_add_memory(int nid, u64 start, u64 size, > > return ret; > > } > > > > -#ifdef CONFIG_NUMA > > -int memory_add_physaddr_to_nid(u64 addr) > > -{ > > - /* Node 0 for now.. */ > > - return 0; > > -} > > -EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); > > -#endif > > - > > void arch_remove_memory(int nid, u64 start, u64 size, > > struct vmem_altmap *altmap) > > { > > > > Reviewed-by: David Hildenbrand Acked-by: Rich Felker