From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Date: Mon, 07 Sep 2020 01:12:26 +0000 Subject: Re: [PATCH v2 08/11] kprobes: switch to kernel_clone() Message-Id: <20200907101226.ab0d00639be953e81d4576c2@kernel.org> List-Id: References: <20200819104655.436656-1-christian.brauner@ubuntu.com> <20200819104655.436656-9-christian.brauner@ubuntu.com> In-Reply-To: <20200819104655.436656-9-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christian Brauner Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Corbet , Yoshinori Sato , Tony Luck , Fenghua Yu , Geert Uytterhoeven , Ley Foon Tan , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Arnd Bergmann , Steven Rostedt , Stafford Horne , Peter Zijlstra , Kars de Jong , Kees Cook , Greentime Hu , "Eric W. Biederman" , Mauro Carvalho Chehab , Alexandre Chartre , Masami Hiramatsu , Tom Zanussi , Xiao Yang , linux-doc@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, sparclinux@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-kselftest@vger.kernel.org, Linus Torvalds , Christoph Hewllig , Matthew Wilcox Hi, On Wed, 19 Aug 2020 12:46:52 +0200 Christian Brauner wrote: > The old _do_fork() helper is removed in favor of the new kernel_clone() helper. > The latter adheres to naming conventions for kernel internal syscall helpers. This looks good to me. Acked-by: Masami Hiramatsu Thank you! > > Cc: Mauro Carvalho Chehab > Cc: Alexandre Chartre > Cc: Jonathan Corbet > Cc: Masami Hiramatsu > Signed-off-by: Christian Brauner > --- > /* v2 */ > unchanged > --- > samples/kprobes/kprobe_example.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c > index 240f2435ce6f..a02f53836ee1 100644 > --- a/samples/kprobes/kprobe_example.c > +++ b/samples/kprobes/kprobe_example.c > @@ -2,13 +2,13 @@ > /* > * NOTE: This example is works on x86 and powerpc. > * Here's a sample kernel module showing the use of kprobes to dump a > - * stack trace and selected registers when _do_fork() is called. > + * stack trace and selected registers when kernel_clone() is called. > * > * For more information on theory of operation of kprobes, see > * Documentation/staging/kprobes.rst > * > * You will see the trace data in /var/log/messages and on the console > - * whenever _do_fork() is invoked to create a new process. > + * whenever kernel_clone() is invoked to create a new process. > */ > > #include > @@ -16,7 +16,7 @@ > #include > > #define MAX_SYMBOL_LEN 64 > -static char symbol[MAX_SYMBOL_LEN] = "_do_fork"; > +static char symbol[MAX_SYMBOL_LEN] = "kernel_clone"; > module_param_string(symbol, symbol, sizeof(symbol), 0644); > > /* For each probe you need to allocate a kprobe structure */ > -- > 2.28.0 > -- Masami Hiramatsu