From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Date: Tue, 22 Sep 2020 21:43:30 +0000 Subject: [PATCH] RCU: export rcu_idle_enter/_exit for loadable modules Message-Id: <20200922214331.26608-1-rdunlap@infradead.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, Peter Zijlstra , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, "Paul E. McKenney" , Josh Triplett , rcu@vger.kernel.org drivers/acpi/processor.ko uses rcu_idle_enter()/_exit() but they are not exported. This causes build errors on IA64, so export those 2 functions. ERROR: modpost: "rcu_idle_enter" [drivers/acpi/processor.ko] undefined! ERROR: modpost: "rcu_idle_exit" [drivers/acpi/processor.ko] undefined! Reported-by: kernel test robot Signed-off-by: Randy Dunlap Cc: Rafael J. Wysocki Cc: linux-acpi@vger.kernel.org Cc: Peter Zijlstra Cc: Tony Luck Cc: Fenghua Yu Cc: linux-ia64@vger.kernel.org Cc: "Paul E. McKenney" Cc: Josh Triplett Cc: rcu@vger.kernel.org --- Is there a problem with exporting these functions for use by loadable modules? If so, this driver should be modified not to use rcu_idle_enter/exit. kernel/rcu/tree.c | 2 ++ 1 file changed, 2 insertions(+) --- lnx-59-rc6.orig/kernel/rcu/tree.c +++ lnx-59-rc6/kernel/rcu/tree.c @@ -673,6 +673,7 @@ void rcu_idle_enter(void) lockdep_assert_irqs_disabled(); rcu_eqs_enter(false); } +EXPORT_SYMBOL_GPL(rcu_idle_enter); #ifdef CONFIG_NO_HZ_FULL /** @@ -886,6 +887,7 @@ void rcu_idle_exit(void) rcu_eqs_exit(false); local_irq_restore(flags); } +EXPORT_SYMBOL_GPL(rcu_idle_exit); #ifdef CONFIG_NO_HZ_FULL /**