From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Date: Mon, 05 Jul 2021 12:03:36 +0000 Subject: Re: [PATCH -tip v8 02/13] kprobes: treewide: Replace arch_deref_entry_point() with dereference_symbo Message-Id: <20210705210336.8428fbf0e65deb1e437374f4@kernel.org> List-Id: References: <162399992186.506599.8457763707951687195.stgit@devnote2> <162399994018.506599.10332627573727646767.stgit@devnote2> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ingo Molnar Cc: Steven Rostedt , Josh Poimboeuf , X86 ML , Daniel Xu , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, kuba@kernel.org, mingo@redhat.com, ast@kernel.org, Thomas Gleixner , Borislav Petkov , Peter Zijlstra , kernel-team@fb.com, yhs@fb.com, linux-ia64@vger.kernel.org, Abhishek Sagar , Andrii Nakryiko On Mon, 5 Jul 2021 09:48:09 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > Replace arch_deref_entry_point() with dereference_symbol_descriptor() > > because those are doing same thing. > > > > Signed-off-by: Masami Hiramatsu > > Tested-by: Andrii Nakryik > > A better changelog: > > ~15 years ago kprobes grew the 'arch_deref_entry_point()' __weak function: > > 3d7e33825d87: ("jprobes: make jprobes a little safer for users") > > But this is just open-coded dereference_symbol_descriptor() in essence, and > its obscure nature was causing bugs. > > Just use the real thing. OK. BTW, I couldn't find actual bugs from it. What about this? "its obscure nature was causing problems in the past." Thank you, > > Thanks, > > Ingo -- Masami Hiramatsu