From mboxrd@z Thu Jan 1 00:00:00 1970 From: Segher Boessenkool Date: Mon, 28 Mar 2022 13:19:28 +0000 Subject: Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers Message-Id: <20220328131928.GH614@gate.crashing.org> List-Id: References: <20220326165909.506926-1-benni@stuerz.xyz> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Arnd Bergmann Cc: Andrew Lunn , "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" , linux-atm-general@lists.sourceforge.net, linux-ia64@vger.kernel.org, linux-pci , Linus Walleij , Dave Hansen , Russell King - ARM Linux , Krzysztof Kozlowski , Alim Akhtar , "H. Peter Anvin" , wcn36xx@lists.infradead.org, Bartosz Golaszewski , Benjamin =?iso-8859-1?Q?St=FCrz?= , Jason Gunthorpe , Pkshih , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , dennis.dalessandro@cornelisnetworks.com, linux-rdma , Gregory CLEMENT , "Rafael J. Wysocki" , Robert Moore , Harald Welte , ACPI Devel Maling List , Ingo Molnar , Sebastian Hesselbarth , Chas Williams <3chas3@gmail.com>, "open list:HID CORE LAYER" , Jakub Kicinski , pabeni@redhat.com, Len Brown , mike.marciniszyn@cornelisnetworks.com, Robert Richter , Andrew Donnellan , kvalo@kernel.org, "open list:GPIO SUBSYSTEM" , Tony Luck , Borislav Petkov , Bjorn Helgaas , Thomas Gleixner , Mauro Carvalho Chehab , Simtec Linux Team , Linux ARM , linux-edac@vger.kernel.org, Karsten Keil , loic.poulain@linaro.org, Pali =?iso-8859-1?Q?Roh=E1r?= , Nicolas Pitre , gregkh , Dmitry Torokhov , linux-wireless , Linux Kernel Mailing List , James Morse , Networking , Frederic Barrat , Linux Media Mailing List , linuxppc-dev , David Miller On Sat, Mar 26, 2022 at 08:23:31PM +0100, Arnd Bergmann wrote: > On Sat, Mar 26, 2022 at 5:58 PM Benjamin St=FCrz wrote: > > > > This replaces comments with C99's designated > > initializers because the kernel supports them now. >=20 > The change looks fine, but the comment looks misplaced, as enum initializ= ers > are not c99 feature. Yes, it is from C89/C90. > Also, the named array and struct intializers have been > supported by gnu89 for a long time and widely used in the kernel, so it's > not a recent change even for the others. GCC supports this since 1998. There was a syntax different from C99 designated initializers (".ans =3D 42") before (namely, "ans: 42"). 1998 is long enough ago for all intents and purposes now of course ;-) Segher