From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Poimboeuf Date: Mon, 06 Feb 2023 22:22:02 +0000 Subject: Re: [PATCH 12/22] powerpc/cpu: Mark start_secondary_resume() __noreturn Message-Id: <20230206222202.zreg3pyhynhvyggy@treble> List-Id: References: <87v8kfdp7l.fsf@mpe.ellerman.id.au> In-Reply-To: <87v8kfdp7l.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michael Ellerman Cc: linux-kernel@vger.kernel.org, jgross@suse.com, richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, linux-alpha@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, jiaxun.yang@flygoat.com, npiggin@gmail.com, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, ysato@users.sourceforge.jp, dalias@libc.org, linux-sh@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, linux-xtensa@linux-xtensa.org, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, paulmck@kernel.org On Mon, Feb 06, 2023 at 10:10:22PM +1100, Michael Ellerman wrote: > Josh Poimboeuf writes: > > start_secondary_resume() doesn't return. Annotate it as such. By > > extension this also makes arch_cpu_idle_dead() noreturn. > > Can we also mark arch_cpu_idle_dead() (the C function) __noreturn ? > > Seems like it would be good documentation, even if it's not required > once the generic prototype is __noreturn. Yeah, agreed. Maybe I'll do that (for all the implementations) with patch 22. > But not a show-stopper. > > Acked-by: Michael Ellerman (powerpc) Thanks! -- Josh