Re: [PATCH] fix setting of sn_hub_info->shub_1_1_found

David Mosberger
2005-06-06T16:57:58Z

>>>>> On Sat, 04 Jun 2005 14:18:16 +1000, Keith Owens <kaos@sgi.com> said:

Keith> On Fri, 3 Jun 2005 11:50:55 -0700,
Keith> "Luck, Tony" <tony.luck@intel.com> wrote:
>>> This explains why XPC has been so troublesome to load on older systems.
>>> Thanks Dean!
>>>
>>> Tony, can this still get into 2.6.12?
>>
>> Probably ... but the first hunk of the patch looks like a no-op,
>> and contravenes some style guidlines about initializing global
>> variables to 0.
>>
>> -static int shub_1_1_found __initdata;
>> +static int __initdata shub_1_1_found = 0;

Keith> There is a linker restriction that you must initialise variables that
Keith> are to be stored in different sections, which is what __initdata does.
Keith> without initialization shub_1_1_found ends up in .bss, with
Keith> initialization it ends up in .init.data.

Interesting. Strikes me as a toolchain-bug, though. Clearly the
__initdata declaration is in conflict with putting the data in .bss,
yet there is no warning or error.

--david