Re: [v4,3/6] fbdev: Include in various drivers

Sui Jingfeng
2023-05-04T11:31:24Z

Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn>

On 2023/5/4 15:45, Thomas Zimmermann wrote:
> The code uses writel() and similar I/O-memory helpers. Include
> the header file to get the declarations.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/video/fbdev/arcfb.c | 1 +
> drivers/video/fbdev/aty/atyfb.h | 2 ++
> drivers/video/fbdev/wmt_ge_rops.c | 2 ++
> 3 files changed, 5 insertions(+)
>
> diff --git a/drivers/video/fbdev/arcfb.c b/drivers/video/fbdev/arcfb.c
> index 45e64016db32..d631d53f42ad 100644
> --- a/drivers/video/fbdev/arcfb.c
> +++ b/drivers/video/fbdev/arcfb.c
> @@ -41,6 +41,7 @@
> #include <linux/vmalloc.h>
> #include <linux/delay.h>
> #include <linux/interrupt.h>
> +#include <linux/io.h>
> #include <linux/fb.h>
> #include <linux/init.h>
> #include <linux/arcfb.h>
> diff --git a/drivers/video/fbdev/aty/atyfb.h b/drivers/video/fbdev/aty/atyfb.h
> index 465f55beb97f..30da3e82ed3c 100644
> --- a/drivers/video/fbdev/aty/atyfb.h
> +++ b/drivers/video/fbdev/aty/atyfb.h
> @@ -3,8 +3,10 @@
> * ATI Frame Buffer Device Driver Core Definitions
> */
>
> +#include <linux/io.h>
> #include <linux/spinlock.h>
> #include <linux/wait.h>
> +
> /*
> * Elements of the hardware specific atyfb_par structure
> */
> diff --git a/drivers/video/fbdev/wmt_ge_rops.c b/drivers/video/fbdev/wmt_ge_rops.c
> index 42255d27a1db..99c7b0aea615 100644
> --- a/drivers/video/fbdev/wmt_ge_rops.c
> +++ b/drivers/video/fbdev/wmt_ge_rops.c
> @@ -9,7 +9,9 @@
>
> #include <linux/module.h>
> #include <linux/fb.h>
> +#include <linux/io.h>
> #include <linux/platform_device.h>
> +
> #include "core/fb_draw.h"
> #include "wmt_ge_rops.h"
>