From: Keith Owens <kaos@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH]Make gp value point to Region 5 in mca handler
Date: Fri, 15 Sep 2006 05:02:33 +0000 [thread overview]
Message-ID: <31039.1158296553@kao2.melbourne.sgi.com> (raw)
In-Reply-To: <1158123325.2591.46.camel@linux-znh>
Zou Nan hai (on 14 Sep 2006 08:25:15 +0800) wrote:
>On Wed, 2006-09-13 at 17:54, Keith Owens wrote:
>> Zou Nan hai (on 13 Sep 2006 12:55:25 +0800) wrote:
>> >The patch set gp register to kernel gp of region 5 at entry of MCA
>> >dispatch.
>> >
>> >Signed-off-by: Zou Nan hai <nanhai.zou@intel.com>
>>
>> The idea is right, but there is no need to pass __gp to
>> VIRTUAL_MODE_ENTER. There will never be a case of VIRTUAL_MODE_ENTER
>> followed by entry to a module, so just hard code 'movl r1 = __gp' into
>> VIRTUAL_MODE_ENTER and drop it from the parameter list.
>
> OK, I felt a little weird to put hard code in a macro.., but I think it
>does not matter much since the macro is only used 2 times.
>
> the updated patch
>
> Signed-off-by: Zou Nan hai <nanhai.zou@intel.com>
Acked-by: Keith Owens <kaos@sgi.com>
BTW, your patch deleted the only use of IA64_SAL_OS_STATE_OS_GP_OFFSET
so that field can also be deleted from arch/ia64/kernel/asm-offsets.c.
prev parent reply other threads:[~2006-09-15 5:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-13 4:55 [PATCH]Make gp value point to Region 5 in mca handler Zou Nan hai
2006-09-13 9:54 ` Keith Owens
2006-09-14 0:25 ` Zou Nan hai
2006-09-15 5:02 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31039.1158296553@kao2.melbourne.sgi.com \
--to=kaos@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox