From: Keith Owens <kaos@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch 1/6] add __init declaration to mca functions
Date: Wed, 15 Mar 2006 05:58:28 +0000 [thread overview]
Message-ID: <31080.1142402308@kao2.melbourne.sgi.com> (raw)
In-Reply-To: <200603121652.k2CGqIg10015@unix-os.sc.intel.com>
"Chen, Kenneth W" (on Sun, 12 Mar 2006 08:52:20 -0800) wrote:
>Mark init related variable and functions with appropriate
>__init* declaration to mca functions.
>
>
>Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
>
>--- ./arch/ia64/kernel/mca.c.orig 2006-03-12 01:23:18.000000000 -0800
>+++ ./arch/ia64/kernel/mca.c 2006-03-12 09:01:44.713161302 -0800
>@@ -133,7 +133,7 @@ static int cpe_poll_enabled = 1;
>
> extern void salinfo_log_wakeup(int type, u8 *buffer, u64 size, int irqsafe);
>
>-static int mca_init;
>+static int mca_init __initdata;
Coding style niggle. Attributes like __initdata usually come before
the variable name, for readibility.
prev parent reply other threads:[~2006-03-15 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-12 16:52 [patch 1/6] add __init declaration to mca functions Chen, Kenneth W
2006-03-15 5:58 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31080.1142402308@kao2.melbourne.sgi.com \
--to=kaos@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox