From: "Natalie Protasevich" <protasnb@gmail.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH 1/1] Allow global purge traslation cache (ptc.g) to bedisabled
Date: Mon, 03 Sep 2007 08:06:02 +0000 [thread overview]
Message-ID: <32209efe0709030106o261aaff8g592a952bee131618@mail.gmail.com> (raw)
In-Reply-To: <200708301338.34246.protasnb@gmail.com>
On 31 Aug 2007 09:48:07 +0800, Zou Nan hai <nanhai.zou@intel.com> wrote:
> On Fri, 2007-08-31 at 09:45, Luck, Tony wrote:
> > > Please consider the scenario when many cpus are calling
> > > ia64_global_tlb_purge at the same time without any lock.
> > > Using global variables to indicate tlb flush start and end is not safe
> > > here.
> >
> > Isn't everything protected by the
> >
> > spin_lock(&ptcg_lock);
> > ...
> > spin_unlock(&ptcg_lock);
> >
> > in ia64_global_tlb_purge()? Though the comment that this lock
> > is required for HW serialization would need to be updated to
> > note that the s/w implementation also requires this serialization.
> >
> > -Tony
>
> Ah Yes, I missed this line when reading the patch...
>
> So my comments would be
> 1. avoid declare global variables and functions in .c file.
> 2. use more precise name for global variable.to e.g
> ia64_global_tlb_flush_start is better than flush_start.
> 3. do not use asm in .c file, use intrins instead.
>
Tony and Zou Nan hai,
Thank you very much for the review.
I am going to re-send the patch, with all the corrections except I
can't really see a good way to accommodate #1. Let me know if you have
specific suggestions on this.
Keith - I really tried to make it not to wrap, hope it will work this time.
Regards,
--Natalie
next prev parent reply other threads:[~2007-09-03 8:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 20:38 [PATCH 1/1] Allow global purge traslation cache (ptc.g) to be disabled Natalie Protasevich
2007-08-31 1:15 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to be Zou Nan hai
2007-08-31 1:45 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to bedisabled Luck, Tony
2007-08-31 1:48 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to Zou Nan hai
2007-09-03 8:06 ` Natalie Protasevich [this message]
2007-09-03 8:06 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to be disabled - take 2 Natalie Protasevich
2007-09-03 9:21 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to be disabled Jes Sorensen
2007-09-03 9:37 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to be disabled - take 2 Jes Sorensen
2007-09-04 8:46 ` Robin Holt
2007-09-04 9:03 ` Luck, Tony
2007-09-04 14:58 ` Natalie Protasevich
2007-09-04 16:05 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to be disabled Natalie Protasevich
2007-09-04 19:59 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to be disabled - take 2 Bjorn Helgaas
2007-09-04 21:20 ` Natalie Protasevich
2007-09-05 13:35 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to be Jes Sorensen
2007-09-05 13:57 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to be disabled Robin Holt
2007-09-05 15:29 ` Natalie Protasevich
2007-09-05 15:47 ` David Mosberger-Tang
2007-09-05 16:01 ` Natalie Protasevich
2007-09-06 16:36 ` David Mosberger-Tang
2007-09-06 18:00 ` Natalie Protasevich
2007-09-07 7:38 ` Luck, Tony
2007-09-07 8:38 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to be Jes Sorensen
2007-09-07 16:11 ` [PATCH 1/1] Allow global purge traslation cache (ptc.g) to be disabled Bjorn Helgaas
2007-09-07 16:25 ` Natalie Protasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32209efe0709030106o261aaff8g592a952bee131618@mail.gmail.com \
--to=protasnb@gmail.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox