From: "Luming Yu" <luming.yu@gmail.com>
To: linux-ia64@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [RFC patch] fallback to "no irq" hack for case of no pnp_irq allocated for 8250_pnp
Date: Wed, 17 Oct 2007 02:50:53 +0000 [thread overview]
Message-ID: <3877989d0710161950n3d255330lf55e190dde628277@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
Hello list,
There is a "ttyS1 irq is -1" problem observed on tiger4 which cause
the serial port broken.
It is because that there is __no__ ACPI IRQ resource assigned for the
serial port. So the value of the IRQ for the port is never changed
since it got initialized to -1. The attached patch falls back to the
"no irq" hack for this case. It works for me. Please review and test.
Thanks,
Luming
Signed-off-by: Yu Luming <luming.yu@intel.com>
8250_pnp.c | 3 +++
1 files changed, 3 insertions(+)
[-- Attachment #2: 8250_pnp.patch --]
[-- Type: application/octet-stream, Size: 451 bytes --]
--- 2.6/drivers/serial/8250_pnp.c.orig 2007-10-16 14:18:19.000000000 +0800
+++ 2.6/drivers/serial/8250_pnp.c 2007-10-16 14:18:30.000000000 +0800
@@ -431,6 +431,9 @@
memset(&port, 0, sizeof(struct uart_port));
port.irq = pnp_irq(dev, 0);
+ /* No irq is assigned for the port, fallback to "no irq" hack */
+ if (port.irq == -1)
+ port.irq = 0;
if (pnp_port_valid(dev, 0)) {
port.iobase = pnp_port_start(dev, 0);
port.iotype = UPIO_PORT;
next reply other threads:[~2007-10-17 2:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 2:50 Luming Yu [this message]
2007-10-17 4:40 ` [RFC patch] fallback to "no irq" hack for case of no pnp_irq allocated for 8250_pnp Matthew Wilcox
2007-10-17 10:49 ` [RFC patch] fallback to "no irq" hack for case of no pnp_irq Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3877989d0710161950n3d255330lf55e190dde628277@mail.gmail.com \
--to=luming.yu@gmail.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox