From: "Luming Yu" <luming.yu@gmail.com>
To: Simon Horman <horms@verge.net.au>
Cc: David Miller <davem@davemloft.net>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@linux.intel.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] fix typo in per_cpu_offset
Date: Wed, 07 Nov 2007 06:50:33 +0000 [thread overview]
Message-ID: <3877989d0711062250g44e5d0ecq1e4b893fa2bad94a@mail.gmail.com> (raw)
In-Reply-To: <20071107064429.GC3571@verge.net.au>
NAK for now.
I'm trying to add lockdep , so please don't delete it until it could
be proved really useless...
Please don't hurry...
On 11/7/07, Simon Horman <horms@verge.net.au> wrote:
> On Tue, Oct 30, 2007 at 05:50:56PM +0900, Simon Horman wrote:
> > On Tue, Oct 30, 2007 at 12:36:22AM -0700, David Miller wrote:
> > > From: Simon Horman <horms@verge.net.au>
> > > Date: Tue, 30 Oct 2007 16:15:13 +0900
> > >
> > > > Though curiuously with my config nothing uses per_cpu_offset()
> > > > (I added a bogus call to produce an error.) Is it actually
> > > > used on ia64?
> > >
> > > It is unused, and in that regard should probably be deleted.
> > >
> > > include/asm-generic/percpu.h defines a seemingly similarly
> > > unused per_cpu_offset() macro define as well
> >
> > It looks like they were both added by "[PATCH] lockdep: add per_cpu_offset()"
> > (a875a69f8b00a38b4f40d9632a4fc71a159f0e0d)
> >
> > Perhaps they were used at that time?
>
> I looked into this a little further:
>
> I'm pretty much convinced that the asm-ia64 version of per_cpu_offset()
> is unused as ia64 doesn't have lockdep. I will send a patch to get rid
> of it. The generic version might be used on mips, sh or arm with
> CONFIG_SMP, as these architectures have lockdep. I did managed to
> produce a compiler error on mips by removing the asm-generic version of
> per_cpu_offset().
>
> --
> Horms
> H: http://www.vergenet.net/~horms/
> W: http://www.valinux.co.jp/en/
>
>
prev parent reply other threads:[~2007-11-07 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 7:15 [PATCH] fix typo in per_cpu_offset Luming Yu
2007-10-30 7:15 ` Simon Horman
2007-10-30 7:36 ` David Miller
2007-10-30 8:50 ` Simon Horman
2007-11-07 6:44 ` Simon Horman
2007-11-07 6:50 ` Luming Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3877989d0711062250g44e5d0ecq1e4b893fa2bad94a@mail.gmail.com \
--to=luming.yu@gmail.com \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox