From: "Luming Yu" <luming.yu@gmail.com>
To: Simon Horman <horms@verge.net.au>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
Yu Luming <luming.yu@intel.com>,
David Miller <davem@davemloft.net>, Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@linux.intel.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] ia64: remove per_cpu_offset()
Date: Wed, 07 Nov 2007 06:55:24 +0000 [thread overview]
Message-ID: <3877989d0711062255r45bdd437ic115fc52d064c59b@mail.gmail.com> (raw)
In-Reply-To: <20071107064627.GD3571@verge.net.au>
NAK for now.
I'm trying to add lockdep , so please don't delete it until it could
be proved really useless...
Please don't hurry...
On 11/7/07, Simon Horman <horms@verge.net.au> wrote:
> per_cpu_offset() was added as part of a lockdep patch,
> "[PATCH] lockdep: add per_cpu_offset()"
> (a875a69f8b00a38b4f40d9632a4fc71a159f0e0d),
> but ia64 doesn't have lockdep, nor does it use per_cpu_offset()
> anywhere else.
>
> This came up because Yu Lumming noticed that the ia64 version
> of per_cpu_offset() actually has a syntax error. Amusing as it seems
> to have been in the tree for months.
>
> > -#define per_cpu_offset(x) (__per_cpu_offset(x))
> > +#define per_cpu_offset(x) (__per_cpu_offset[x])
>
> Dave Miller suggested that rather than fixing the unused code it would be
> better to just remove it all together.
>
> Signed-off-by: Simon Horman <horms@verge.net.au>
>
> diff --git a/include/asm-ia64/percpu.h b/include/asm-ia64/percpu.h
> index c4f1e32..2870f8d 100644
> --- a/include/asm-ia64/percpu.h
> +++ b/include/asm-ia64/percpu.h
> @@ -46,7 +46,6 @@
> #ifdef CONFIG_SMP
>
> extern unsigned long __per_cpu_offset[NR_CPUS];
> -#define per_cpu_offset(x) (__per_cpu_offset[x])
>
> /* Equal to __per_cpu_offset[smp_processor_id()], but faster to access: */
> DECLARE_PER_CPU(unsigned long, local_per_cpu_offset);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2007-11-07 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 6:46 [patch] ia64: remove per_cpu_offset() Simon Horman
2007-11-07 6:55 ` Luming Yu [this message]
2007-11-07 9:13 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3877989d0711062255r45bdd437ic115fc52d064c59b@mail.gmail.com \
--to=luming.yu@gmail.com \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@intel.com \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox