Re: [PATCH] Altix console mod

[Patrick Gefre <pfg@sgi.com>]

Andreas Schwab wrote:
> Pat Gefre <pfg@sgi.com> writes:
> 
> 
>>@@ -978,19 +981,21 @@
>>  * ia64_sn_console_putb (what sal_puts_raw below actually does).
>>  *
>>  */
>>-static void puts_raw_fixed(const char *s, int count)
>>+
>>+static void puts_raw_fixed(int (*puts_raw) (const char *s, int len), const char *s, int count)
>> {
>> 	const char *s1;
>>-	struct sn_cons_port *port = &sal_console_port;
>> 
>> 	/* Output '\r' before each '\n' */
>> 	while ((s1 = memchr(s, '\n', count)) != NULL) {
>>-		port->sc_ops->sal_puts_raw(s, s1 - s);
>>-		port->sc_ops->sal_puts_raw("\r\n", 2);
>>+		if ( (*(s1 - 1) != '\r') && (*(s1 + 1) != '\r') ) {
>>+			puts_raw(s, s1 - s);
>>+			puts_raw("\r\n", 2);
>>+		}
> 
> 
> You have now broken output when a CR actually appears in the string.
> What's wrong with unconditionally writing a CR before each LF?  That's
> what every other console print function is doing.
> 
> Andreas.
> 

You're right, I forgot the else on the if (to write out the lf) ....
So send the cr even if one is already there - guess it doesn't hurt ?

-- Pat