On 10/4/2004 8:45 AM, David Mosberger wrote: Hi David, > Arun, > > copy_siginfo_from_user32() directly dereferences a user-pointer, which > is a no-no. At that point, to->si_code already has been initialized > so I think we can just use to->si_code instead. Compile-tested (only) > patch attached. > > Signed-off-by: davidm@hpl.hp.com I've been meaning to run sparse myself. But it wasn't very effective the last time I tried because of the missing __user annotations. Please review the attached patches that add the missing annotations so that we can make it easy to spot these errors in the future. -Arun