From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arun Sharma Date: Fri, 14 Jan 2005 23:36:13 +0000 Subject: Re: [patch] add BUG call to overlapping vma fix Message-Id: <41E8576D.9060802@intel.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ia64@vger.kernel.org On 1/14/2005 8:52 AM, Jason Baron wrote: > hi, > > It seems that in ia64_elf32_init, instead of calling return, if we insert > an overlapping vma, we should instead BUG(). We should never get into this > code path, because the vma's are set above PAGE_OFFSET, and thus a > Xmalicious user can not trigger this code path. This change is being > suggested mainly for clarity. Thanks to Stephen Tweedie for pointing out > that returning early in ia64_elf32_init could have unpredictable results. > Couldn't you get rid of a couple of more lines before the BUG()? Otherwise, the patch looks good to me. -Arun