Re: [PATCH 03/10] IOCHK interface for I/O error handling/detecting

Matthew Wilcox
2005-06-09T17:20:35Z

On Thu, Jun 09, 2005 at 09:51:57PM +0900, Hidetoshi Seto wrote:
> + switch (dev->hdr_type) {
> + case PCI_HEADER_TYPE_NORMAL: /* 0 */
> + pci_read_config_word(dev, PCI_STATUS, &status);
> + break;
> + case PCI_HEADER_TYPE_BRIDGE: /* 1 */
> + pci_read_config_word(dev, PCI_SEC_STATUS, &status);
> + break;
> + case PCI_HEADER_TYPE_CARDBUS: /* 2 */
> + default:
> + BUG();

If somebody plugs a cardbus card into an ia64 machine, we BUG()?
Unacceptable. Just return 0 if you don't know what to do with a
particular device.

--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain