public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] mca_drv cleanup
Date: Fri, 16 Sep 2005 04:36:28 +0000	[thread overview]
Message-ID: <432A4BCC.2070802@jp.fujitsu.com> (raw)
In-Reply-To: <432A38A9.509@jp.fujitsu.com>

Peter Chubb wrote:
> If you're going to tidy those up, how about changing the style to
> conform to Documentation/CodingStyle at the same time?
> 
>  	/* whether physical address is valid or not */ 
> - if ( !ia64_phys_addr_valid(paddr) ) 
> + if ( !ia64_phys_addr_valid(paddr) ) return ISOLATE_NG;
> 
> e.g., 
>   if (!ia64_phys_addr_valid(paddr))
> 	return ISOLATE_NG;

Thank you for pointing it out.
The attached new one has additional coding style fixes.

Thanks,
H.Seto


There were some trailing white spaces, long lines, brackets in
weird style etc.  This patch cleans them up.

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>


  parent reply	other threads:[~2005-09-16  4:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-16  3:14 [PATCH] mca_drv cleanup Hidetoshi Seto
2005-09-16  3:27 ` Peter Chubb
2005-09-16  4:36 ` Hidetoshi Seto [this message]
2005-09-16  4:44 ` Hidetoshi Seto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=432A4BCC.2070802@jp.fujitsu.com \
    --to=seto.hidetoshi@jp.fujitsu.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox