From: xb <xavier.bru@bull.net>
To: linux-ia64@vger.kernel.org
Subject: sal record header concern
Date: Mon, 12 Dec 2005 10:02:54 +0000 [thread overview]
Message-ID: <439D4ACE.9020701@bull.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]
Hello Keith and all
It seems there is a concern around the SAL record header:
SEVERITY item is defined as a 8 bits item in SAL documentation
($B.2.1 rev december 2003), but as an u16 in sal.h.
This has the side effect that current code in mca.c does not call
ia64_sal_clear_state_info() upon receiving corrected platform errors
(priority is reported as 258 instead of 2).
--- linux-2.6.12.6/include/asm-ia64/sal.h~ 2005-08-29
18:55:27.000000000 +0200
+++ linux-2.6.12.6/include/asm-ia64/sal.h 2005-12-12
10:19:17.000000000 +0100
@@ -320,7 +320,8 @@
typedef struct sal_log_record_header {
u64 id; /* Unique monotonically increasing ID */
sal_log_revision_t revision; /* Major and Minor revision of
header */
- u16 severity; /* Error Severity */
+ u8 severity; /* Error Severity */
+ u8 validation_bits; /* Validation Bits */
u32 len; /* Length of this error log in bytes */
sal_log_timestamp_t timestamp; /* Timestamp */
efi_guid_t platform_guid; /* Unique OEM Platform ID */
[-- Attachment #2: xavier.bru.vcf --]
[-- Type: text/x-vcard, Size: 304 bytes --]
begin:vcard
fn:Xavier Bru
n:Bru;Xavier
adr:;;1 rue de Provence, BP 208;38432 Echirolles Cedex;;;France
email;internet:Xavier.Bru@bull.net
title:BULL/DT/Open Software/linux/ia64
tel;work:+33 (0)4 76 29 77 45
tel;fax:+33 (0)4 76 29 77 70
x-mozilla-html:TRUE
url:http://www.bull.com
version:2.1
end:vcard
next reply other threads:[~2005-12-12 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-12 10:02 xb [this message]
2005-12-13 4:11 ` sal record header concern Keith Owens
2005-12-13 4:57 ` Luck, Tony
2005-12-13 5:13 ` Keith Owens
2005-12-13 13:51 ` xb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439D4ACE.9020701@bull.net \
--to=xavier.bru@bull.net \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox