From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Mahoney Date: Mon, 09 Jan 2006 17:32:51 +0000 Subject: Re: [PATCH] ia64: including alone causes compilation Message-Id: <43C29E43.8030405@suse.com> List-Id: References: <20060109171514.GA25096@locomotive.unixthugs.org> <20060109172554.GA3026@infradead.org> In-Reply-To: <20060109172554.GA3026@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: linux-ia64@vger.kernel.org, Linux Kernel Mailing List -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Christoph Hellwig wrote: > On Mon, Jan 09, 2006 at 12:15:14PM -0500, Jeff Mahoney wrote: >> Including *just* on ia64 will result in a compilation failure, >> where it will succeed on every other architecture. >> >> Every other arch includes either directly or via >> at the top of . ia64 includes >> after including , which causes >> the __user in to get passed through untouched, causing >> compilation errors. >> >> This patch moves the #include up to the beginning of signal.h, >> as found on every other arch. >> >> A specific example of where this behavior is observed is the recent addition >> of OCFS2. fs/ocfs2/cluster/userdlm.c seems alone in only including >> , which seems to be perfectly valid. > > Generally you should only include via , which gets > via Ok. I just did a quick grep and saw a number of places where was included. A closer look reveals most of those are in arch/. Ignore the noise. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDwp5DLPWxlyuTD7IRAoZBAKCf4MMQNC/rfcdXOH0Dto3RTa32qgCfSeFf pX68kyrbj2ZdH23Mo+EmUZ4=y7xp -----END PGP SIGNATURE-----