Greg KH wrote: > No, we don't need a linux/msi.h, these are core pci things that no one > else should care about. The other arches handle this just fine, let's > not mess everything up just because ia64 can't get it right :) Hmm, it sounds asm/msi.h shouldn't be included from common headers. :< I think the attached patch might be better. How about this? Default msi_arch_init() looks sufficient for most ia64 platforms except for SGI SN2, which seems to need its special version. gregkh-pci-msi-vector-targeting-abstractions.patch used machvec to switch the functions between platforms. For that, it included asm/msi.h from asm/machvec.h and caused the warnings flood. The attached patch separates machvec function and the original inline function. So that we don't need to include asm/msi.h from common headers. There is another problem that CONFIG_IA64_GENERIC still doesn't build due to error in SGI SN specific code. It needs additional fix. Thanks, -- Jun'ichi Nomura, NEC Solutions (America), Inc.