From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Date: Sat, 15 Apr 2006 05:32:10 +0000 Subject: Re: [PATCH 00/05] robust per_cpu allocation for modules Message-Id: <4440855A.7040203@yahoo.com.au> List-Id: References: <1145049535.1336.128.camel@localhost.localdomain> In-Reply-To: <1145049535.1336.128.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steven Rostedt Cc: LKML , Andrew Morton , Linus Torvalds , Ingo Molnar , Thomas Gleixner , Andi Kleen , Martin Mares , bjornw@axis.com, schwidefsky@de.ibm.com, benedict.gaster@superh.com, lethal@linux-sh.org, Chris Zankel , Marc Gauthier , Joe Taylor , David Mosberger-Tang , rth@twiddle.net, spyro@f2s.com, starvik@axis.com, tony.luck@intel.com, linux-ia64@vger.kernel.org, ralf@linux-mips.org, linux-mips@linux-mips.org, grundler@parisc-linux.org, parisc-linux@parisc-linux.org, linuxppc-dev@ozlabs.org, paulus@samba.org, linux390@de.ibm.com, davem@davemloft.net Steven Rostedt wrote: > would now create a variable called per_cpu_offset__myint in > the .data.percpu_offset section. This variable will point to the (if > defined in the kernel) __per_cpu_offset[] array. If this was a module > variable, it would point to the module per_cpu_offset[] array which is > created when the modules is loaded. If I'm following you correctly, this adds another dependent load to a per-CPU data access, and from memory that isn't node-affine. If so, I think people with SMP and NUMA kernels would care more about performance and scalability than the few k of memory this saves. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com