From: Keith Owens <kaos@ocs.com.au>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH 4/8] ia64/pv_ops: paravirtualize arch/ia64/kernel/switch_leave.S
Date: Tue, 26 Feb 2008 21:14:21 +0000 [thread overview]
Message-ID: <4471.1204060461@ocs10w> (raw)
In-Reply-To: <12040343393726-git-send-email-yamahata@valinux.co.jp>
Isaku Yamahata (on Tue, 26 Feb 2008 22:58:55 +0900) wrote:
> /*
> * ia64_leave_syscall(): Same as ia64_leave_kernel, except that it doesn't
>@@ -153,7 +165,8 @@ END(__ia64_switch_to)
> * ar.csd: cleared
> * ar.ssd: cleared
> */
>-GLOBAL_ENTRY(__ia64_leave_syscall)
>+GLOBAL_ENTRY(__paravirt_leave_syscall)
>+ BR_IF_NATIVE(__ia64_leave_syscall, r22, p7)
> PT_REGS_UNWIND_INFO(0)
Move BR_IF_NATIVE after PT_REGS_UNWIND_INFO. PT_REGS_UNWIND_INFO must
define the unwind state at slot 0 of this function to get correct
unwind state. When virtualized, BR_IF_NATIVE will generate extra code
and move the unwind data past slot 0, breaking the backtrace.
>-GLOBAL_ENTRY(__ia64_leave_kernel)
>+GLOBAL_ENTRY(__paravirt_leave_kernel)
>+ BR_IF_NATIVE(__ia64_leave_kernel, r22, p7)
> PT_REGS_UNWIND_INFO(0)
Ditto.
prev parent reply other threads:[~2008-02-26 21:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 13:58 [PATCH 4/8] ia64/pv_ops: paravirtualize arch/ia64/kernel/switch_leave.S Isaku Yamahata
2008-02-26 21:14 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4471.1204060461@ocs10w \
--to=kaos@ocs.com.au \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox