From: Prarit Bhargava <prarit@redhat.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] fix prom revision checks in SN kernel
Date: Wed, 28 Jun 2006 10:50:51 +0000 [thread overview]
Message-ID: <44A25F0B.80204@redhat.com> (raw)
In-Reply-To: <200606271946.MAA19328@google.engr.sgi.com>
>
> Index: linux/drivers/pci/hotplug/sgi_hotplug.c
> =================================> --- linux.orig/drivers/pci/hotplug/sgi_hotplug.c 2006-04-11 00:33:26.000000000 -0500
> +++ linux/drivers/pci/hotplug/sgi_hotplug.c 2006-06-26 14:53:15.693480748 -0500
> @@ -553,7 +553,7 @@
> int rc;
> int registered = 0;
>
> - if (sn_sal_rev() < SGI_HOTPLUG_PROM_REV) {
> + if (is_shub1() && sn_sal_rev() < SGI_HOTPLUG_PROM_REV) {
> printk(KERN_ERR "%s: PROM version must be greater than 4.30\n",
> __FUNCTION__);
> return -EPERM;
> -
This should probably go to pcihpd-discuss ... But, I recall changing
this to use feature sets at some point. I'm surprised it is still in
the code.
Greg, I cannot recall where you queue your patches -- would you mind
fwd'ing a link?
Thanks,
P.
>
next prev parent reply other threads:[~2006-06-28 10:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 19:46 [PATCH] fix prom revision checks in SN kernel Aaron Young
2006-06-27 21:00 ` Luck, Tony
2006-06-27 21:24 ` Aaron Young
2006-06-27 21:54 ` Luck, Tony
2006-06-27 22:09 ` Aaron Young
2006-06-27 22:16 ` Luck, Tony
2006-06-28 10:44 ` Prarit Bhargava
2006-06-28 10:50 ` Prarit Bhargava [this message]
2006-06-28 11:08 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A25F0B.80204@redhat.com \
--to=prarit@redhat.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox