From: Jes Sorensen <jes@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: NODE_DATA without CONFIG_NUMA
Date: Mon, 04 Sep 2006 08:05:30 +0000 [thread overview]
Message-ID: <44FBDE4A.80405@sgi.com> (raw)
In-Reply-To: <20060904062323.GA9293@verge.net.au>
Horms wrote:
> Which I believe is because nodedata.h is not included, as per
> ~line 83 of include/asm/processor.h
>
> #ifdef CONFIG_NUMA
> #include <asm/nodedata.h>
> #endif
>
> Including nodedata.h doesn't seem appropriate, as it does seem to
> be numa-specific. I wasn't able to find an alternate definition of
> CONFIG_NUMA
IMHO nodedata.h should provide alternative macros for non NUMA builds.
It seems silly to protect the include with #ifdef.
Cheers,
Jes
--
VGER BF report: U 0.5
next prev parent reply other threads:[~2006-09-04 8:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 6:23 NODE_DATA without CONFIG_NUMA Horms
2006-09-04 6:37 ` KAMEZAWA Hiroyuki
2006-09-04 7:06 ` Horms
2006-09-04 7:43 ` Jes Sorensen
2006-09-04 7:45 ` KAMEZAWA Hiroyuki
2006-09-04 7:56 ` Horms
2006-09-04 8:05 ` Jes Sorensen [this message]
2006-09-04 8:22 ` Horms
2006-09-04 8:55 ` Jes Sorensen
2006-09-04 16:15 ` Christoph Lameter
2006-09-04 17:15 ` Jes Sorensen
2006-09-04 17:39 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FBDE4A.80405@sgi.com \
--to=jes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox