public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [discuss] swiotlb_sync_sg() issue?
Date: Tue, 19 Dec 2006 13:26:47 +0000	[thread overview]
Message-ID: <4587F6A7.76E4.0078.0@novell.com> (raw)
In-Reply-To: <4587D6D3.76E4.0078.0@novell.com>

>>> "Jan Beulich" <jbeulich@novell.com> 19.12.06 12:10 >>>
>Due to its apparent obviousness, I'm afraid I'm missing something, but isn't it
>incorrect that lib/swiotlb.c:swiotlb_sync_sg() calls sync_single() with
>sg->dma_address simply cast to void* rather than going through phys_to_virt()?
>
>Also, for ia64, isn't mark_clean() violating its own comment, i.e. to mark only
>*complete* pages? And then, for completeness, isn't swiotlb_sync_sg() missing
>the call to mark_clean()?

Okay, I see I mis-read mark_clean(), it's not violating what it claims to do. But
the other two questions remain.

Thanks, Jan

      reply	other threads:[~2006-12-19 13:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-19 11:10 swiotlb_sync_sg() issue? Jan Beulich
2006-12-19 13:26 ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4587F6A7.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox