From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] Cache error recovery
Date: Wed, 20 Dec 2006 01:33:29 +0000 [thread overview]
Message-ID: <458892E9.3060404@jp.fujitsu.com> (raw)
In-Reply-To: <200612191705.kBJH5e0s69613196@clink.americas.sgi.com>
Russ Anderson wrote:
> @@ -688,11 +690,11 @@ recover_from_processor_error(int platfor
> * The cache check and bus check bits have four possible states
> * cc bc
> * 0 0 Weird record, not recovered
> - * 1 0 Cache error, not recovered
> + * 1 0 Cache error, attempt recovered
> * 0 1 I/O error, attempt recovery
> * 1 1 Memory error, attempt recovery
> */
Which is right, attempt-"recovered" or "recovery"?
> - if (psp->bc = 0 || pbci = NULL)
> + if (psp->cc = 0 && (psp->bc = 0 || pbci = NULL))
> return fatal_mca("No bus check");
The message should be replaced by more appropriate one...
"No recoverable check" or just "Weird record"?
And also there are some comments need to be fixed since this
patch makes it incorrect, ex.
> /*
> * Well, here is only one bus error.
> */
Thanks,
H.Seto
next prev parent reply other threads:[~2006-12-20 1:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-19 17:05 [patch] Cache error recovery Russ Anderson
2006-12-20 1:33 ` Hidetoshi Seto [this message]
2006-12-20 17:32 ` Russ Anderson
2006-12-21 1:58 ` Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458892E9.3060404@jp.fujitsu.com \
--to=seto.hidetoshi@jp.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox