public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch 3/3] IA64: virt_to_page() can be called with NULL arg
Date: Wed, 20 Dec 2006 10:59:50 +0000	[thread overview]
Message-ID: <458917A6.3060509@sgi.com> (raw)
In-Reply-To: <200612192104.kBJL4iBg010376@shell0.pdx.osdl.net>

Kirill Korotaev wrote:
> Jes,
> 
>> Well you suggested a patch which just hides the problem. I suggest you
>> change it to have the BUG_ON().
> IMHO you are wrong.
> the suggested patch *fixes* one particular place, which can be triggered on
> mainstream IA64 by a standard user and is actually a *SECURITY* bug which
> can be potentially exploited (when OOM killer is enabled).
> It doesn't hide anything, It just doesn't help to catch other places.

Hi Kirill,

See my response to Andrew, you are indeed right.

I'll go back and hide in my corner in shame :-(

Cheers,
Jes

      parent reply	other threads:[~2006-12-20 10:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-19 21:04 [patch 3/3] IA64: virt_to_page() can be called with NULL arg akpm
2006-12-20  9:31 ` Jes Sorensen
2006-12-20  9:48 ` Jes Sorensen
2006-12-20  9:52 ` Kirill Korotaev
2006-12-20 10:14 ` Jes Sorensen
2006-12-20 10:19 ` Kirill Korotaev
2006-12-20 10:47 ` Andrew Morton
2006-12-20 10:54 ` Jes Sorensen
2006-12-20 10:57 ` Kirill Korotaev
2006-12-20 10:59 ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=458917A6.3060509@sgi.com \
    --to=jes@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox