From: Jay Lan <jlan@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Fastboot] [PATCH] kexec: Avoid migration of already disabled
Date: Wed, 31 Jan 2007 02:58:09 +0000 [thread overview]
Message-ID: <45C005C1.5010606@sgi.com> (raw)
Magnus Damm wrote:
> kexec: Avoid migration of already disabled irqs (ia64)
>
> This patch fixes up ia64 kexec support for HP rx2620 hardware. It does this
> by skipping migration of already disabled irqs. This is most likely a problem
> on other ia64 platforms as well, but I've only tested this on one machine
> so far.
I have not seen this problem on SN systems.
Cheers,
- jay
>
> The full story is that handle_bad_irq() gets invoked before starting the new
> kernel without this patch. This seems to happen when fixup_irqs() calls
> generic_handle_irq() on already migrated (and disabled) irqs. So by avoiding
> migration of disabled irqs we stay away of handle_bad_irq().
>
> Signed-off-by: Magnus Damm <magnus@valinux.co.jp>
> ---
>
> Tested using kexec-tools-testing 7792798a79b78a5d566f70c9f00237d050b01350
> on HP rx2620 hardware.
>
> Applies on top of 2.6.20-rc6.
>
> arch/ia64/kernel/irq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- 0001/arch/ia64/kernel/irq.c
> +++ 0004/arch/ia64/kernel/irq.c 2007-01-30 12:35:10.000000000 +0900
> @@ -122,6 +122,9 @@ static void migrate_irqs(void)
> for (irq=0; irq < NR_IRQS; irq++) {
> desc = irq_desc + irq;
>
> + if (desc->status = IRQ_DISABLED)
> + continue;
> +
> /*
> * No handling for now.
> * TBD: Implement a disable function so we can now
> _______________________________________________
> fastboot mailing list
> fastboot@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/fastboot
next reply other threads:[~2007-01-31 2:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 2:58 Jay Lan [this message]
2007-01-31 3:49 ` [Fastboot] [PATCH] kexec: Avoid migration of already disabled irqs (ia64) Magnus Damm
2007-01-31 4:54 ` Zou, Nanhai
2007-01-31 5:57 ` Magnus Damm
2007-01-31 6:07 ` Zou, Nanhai
2007-01-31 18:09 ` [Fastboot] [PATCH] kexec: Avoid migration of already disabled Jay Lan
2007-02-01 6:02 ` [Fastboot] [PATCH] kexec: Avoid migration of already disabled irqs (ia64) Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C005C1.5010606@sgi.com \
--to=jlan@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox