From: Mike Habeck <habeck@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] SGI Altix : fix pcibr_dmamap_ate32() bug
Date: Fri, 06 Apr 2007 18:53:59 +0000 [thread overview]
Message-ID: <46169747.BC2CB260@sgi.com> (raw)
In-Reply-To: <20070406170439.24071.57637.75833@attica.americas.sgi.com>
"Luck, Tony" wrote:
>
> Can you explain this part of the patch?
>
> -#define PCI32_ATE_CO (0x1 << 1)
> -#define PCI32_ATE_PREC (0x1 << 2)
> +#define PCI32_ATE_CO (0x1 << 1) /* PIC ASIC ONLY */
> +#define PCI32_ATE_PIO (0x1 << 1) /* TIOCP ASIC ONLY */
>
> Why is PCI32_ATE_PIO now the same value as PCI_ATE_CO?
The ATE (Address Translation Entry for 32bit PCI mappings) Attribute
bits are different for our PIC Bridge ASIC and our TIOCP Bridge ASIC.
On our PIC Bridge ASIC bit#1 is the `Coherent Translation' attribute,
but on our TIOCP Bridge ASIC bit#1 is the `PIO' attribute
-mike
prev parent reply other threads:[~2007-04-06 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 17:04 [PATCH] SGI Altix : fix pcibr_dmamap_ate32() bug Mike Habeck
2007-04-06 17:16 ` Luck, Tony
2007-04-06 18:53 ` Mike Habeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46169747.BC2CB260@sgi.com \
--to=habeck@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox