From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] ia64: Fix incorrect return value from ia64_setup_msi_irq()
Date: Tue, 30 Oct 2007 07:01:49 +0000 [thread overview]
Message-ID: <4726D6DD.9090300@jp.fujitsu.com> (raw)
Hi,
Here is a patch to fix the problem that pci_enable_msi() always fails
on ia64 platform.
Thanks,
Kenji Kaneshige
---
Fix the problem that pci_enable_msi() fails on ia64 platform. The cause of
this problem is incorrect return value of ia64_setup_msi_irq(). It must
return 0 on success, instead of irq number.
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
---
arch/ia64/kernel/msi_ia64.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.24-rc1/arch/ia64/kernel/msi_ia64.c
=================================--- linux-2.6.24-rc1.orig/arch/ia64/kernel/msi_ia64.c
+++ linux-2.6.24-rc1/arch/ia64/kernel/msi_ia64.c
@@ -109,7 +109,7 @@ int ia64_setup_msi_irq(struct pci_dev *p
write_msi_msg(irq, &msg);
set_irq_chip_and_handler(irq, &ia64_msi_chip, handle_edge_irq);
- return irq;
+ return 0;
}
void ia64_teardown_msi_irq(unsigned int irq)
next reply other threads:[~2007-10-30 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 7:01 Kenji Kaneshige [this message]
2007-10-30 17:36 ` [PATCH] ia64: Fix incorrect return value from ia64_setup_msi_irq() Rick Jones
2007-10-30 19:09 ` Ramkrishna Vepa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4726D6DD.9090300@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox