From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Wed, 27 Apr 2016 12:44:34 +0000 Subject: Re: [PATCH 6/8] char/genrtc: parisc: use asm-generic/rtc.h Message-Id: <4737487.5iYaado825@wuerfel> List-Id: References: <1461707052-1337718-1-git-send-email-arnd@arndb.de> <4599222.az1Zyv5Lrl@wuerfel> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Rolf Eike Beer , Greg Kroah-Hartman , Tony Luck , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Michael Ellerman , Rich Felker , David Howells , Koichi Yasutake , Richard Henderson , Ivan Kokshaysky , alpha , the arch/x86 maintainers , Alessandro Zummo , Alexandre Belloni , "linux-kernel@vger.kernel.org" , "linux-ia64@vger.kernel.org" , Parisc List , "linuxppc-dev@lists.ozlabs.org" On Wednesday 27 April 2016 13:55:43 Geert Uytterhoeven wrote: > On Wed, Apr 27, 2016 at 1:35 PM, Arnd Bergmann wrote: > > On Wednesday 27 April 2016 13:21:16 Arnd Bergmann wrote: > >> On Wednesday 27 April 2016 00:07:47 Rolf Eike Beer wrote: > >> > Arnd Bergmann wrote: > >> > > The asm-generic/rtc.h header can now be included by > >> > > architectures that provide their own set_rtc_time/get_rtc_time > >> > > macros, letting us remove most of the common contents in > >> > > the powerpc implementation. > >> > > >> > parisc in this case. > >> > > >> > >> Fixed, thanks! > > > > Actually, after the comment about just removing the gen_rtc driver > > in the long run, I checked again and found that PARISC unconditionally > > selects RTC_CLASS, so this driver can't even be built here. > > We should just remove the header and drop PARISC from the list. > > > > If we also drop m68k, that just leaves powerpc. > > I've just checked Debian's unofficial linux-image-4.5.0-1-m68k_4.5.1-1_m68k, > and it also enables RTC_CLASS and CONFIG_RTC_DRV_GENERIC, so gen_rtc > can be dropped on m68k for sure. Ok, excellent. I'll try to rework the series then to completely eliminate the driver (or leaving it ppc-only). Arnd