From: Zoltan Menyhart <Zoltan.Menyhart@bull.net>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch 1/3] IA64: Slim down __clear_bit_unlock
Date: Thu, 22 Nov 2007 08:40:16 +0000 [thread overview]
Message-ID: <47454070.3020002@bull.net> (raw)
In-Reply-To: <200711212258.lALMwPnR013399@imap1.linux-foundation.org>
Almost there :-)
> +static __inline__ void
> +__clear_bit_unlock(int nr, volatile void *addr)
> +{
> + __u32 mask, new;
> + volatile __u32 *m;
> +
> + m = (volatile __u32 *)addr + (nr >> 5);
Still cannot see why you need an ".acq" on this load.
Why do you use "volatile"?
What about this one?
static __inline__ void
__clear_bit_unlock(int const nr, void * const addr)
{
__u32 * const m = addr + (nr >> 5);
__u32 new;
new = *m & ~(1 << (nr & 31));
barrier();
asm volatile ("st4.rel.nta [%0] = %1\n\t" :: "r"(m), "r"(new));
}
Thanks,
Zoltan Menyhart
next prev parent reply other threads:[~2007-11-22 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 22:58 [patch 1/3] IA64: Slim down __clear_bit_unlock akpm
2007-11-22 8:40 ` Zoltan Menyhart [this message]
2007-12-13 23:58 ` akpm
2008-01-02 9:54 ` Zoltan Menyhart
2008-01-02 20:19 ` Christoph Lameter
2008-01-03 13:36 ` Zoltan Menyhart
2008-01-03 22:14 ` Luck, Tony
2008-01-11 2:02 ` Nick Piggin
2008-01-15 13:15 ` [patch 1/3] IA64: Slim down __clear_bit_unlock #2 Zoltan Menyhart
2008-01-16 6:26 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47454070.3020002@bull.net \
--to=zoltan.menyhart@bull.net \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox