public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] Fix large MCA bootmem allocation
Date: Wed, 06 Feb 2008 00:30:17 +0000	[thread overview]
Message-ID: <47A8FF99.2040700@jp.fujitsu.com> (raw)
In-Reply-To: <20080205193232.GA8834@sgi.com>

Russ Anderson wrote:
> The MCA code allocates bootmem memory for NR_CPUS, regardless
> of how many cpus the system actually has.

So... how about using num_possible_cpus() instead?

> @@ -1762,11 +1762,8 @@ format_mca_init_stack(void *mca_data, un
>  /* Caller prevents this from being called after init */
>  static void * __init_refok mca_bootmem(void)
>  {
> -	void *p;
> -
> -	p = alloc_bootmem(sizeof(struct ia64_mca_cpu) * NR_CPUS +
> -	                  KERNEL_STACK_SIZE);
> -	return (void *)ALIGN((unsigned long)p, KERNEL_STACK_SIZE);
> +	return __alloc_bootmem(sizeof(struct ia64_mca_cpu),
> +	                    KERNEL_STACK_SIZE, 0);
>  }
>  
>  /* Do per-CPU MCA-related initialization.  */

i.e.
p = alloc_bootmem(sizeof(struct ia64_mca_cpu) * num_possible_cpus() +
	                  KERNEL_STACK_SIZE);

Thanks,
H.Seto

  parent reply	other threads:[~2008-02-06  0:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 19:32 [patch] Fix large MCA bootmem allocation Russ Anderson
2008-02-05 20:21 ` Bjorn Helgaas
2008-02-05 23:12 ` Russ Anderson
2008-02-05 23:24 ` Bjorn Helgaas
2008-02-05 23:54 ` Luck, Tony
2008-02-05 23:54 ` Russ Anderson
2008-02-06  0:00 ` Luck, Tony
2008-02-06  0:30 ` Hidetoshi Seto [this message]
2008-02-06  1:34 ` Robin Holt
2008-02-06  2:23 ` Hidetoshi Seto
2008-02-06  3:50 ` Hidetoshi Seto
2008-02-06 10:44 ` Robin Holt
2008-02-06 12:39 ` Hidetoshi Seto
2008-02-06 13:22 ` Robin Holt
2008-02-06 15:13 ` Russ Anderson
2008-02-06 23:32 ` Russ Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A8FF99.2040700@jp.fujitsu.com \
    --to=seto.hidetoshi@jp.fujitsu.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox