From: Jeremy Fitzhardinge <jeremy@goop.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH 20/28] ia64/xen: domU xen machine vector without dma api.
Date: Thu, 21 Feb 2008 23:08:15 +0000 [thread overview]
Message-ID: <47BE045F.6000604@goop.org> (raw)
yamahata@valinux.co.jp wrote:
> diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c
> index 78f28d8..9c17a46 100644
> --- a/arch/ia64/kernel/acpi.c
> +++ b/arch/ia64/kernel/acpi.c
> @@ -118,6 +118,10 @@ acpi_get_sysname(void)
> return "hpzx1";
> } else if (!strcmp(hdr->oem_id, "SGI")) {
> return "sn2";
> +#ifdef CONFIG_XEN
> + } else if (is_running_on_xen() && !strcmp(hdr->oem_id, "XEN")) {
> + return "xen";
> +#endif
> }
Is the #ifdef necessary? Couldn't you make is_running_on_xen() just
evaluate to 0 in the non-Xen case?
J
next reply other threads:[~2008-02-21 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 23:08 Jeremy Fitzhardinge [this message]
2008-02-22 5:10 ` [PATCH 20/28] ia64/xen: domU xen machine vector without dma api Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BE045F.6000604@goop.org \
--to=jeremy@goop.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox