From: Jeremy Fitzhardinge <jeremy@goop.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH 19/28] ia64/xen: xen domU irq chip introducing some helper
Date: Thu, 21 Feb 2008 23:22:54 +0000 [thread overview]
Message-ID: <47BE07CE.5090008@goop.org> (raw)
yamahata@valinux.co.jp wrote:
> diff --git a/arch/ia64/kernel/irq_ia64.c b/arch/ia64/kernel/irq_ia64.c
> index 0b52f19..b5dcb49 100644
> --- a/arch/ia64/kernel/irq_ia64.c
> +++ b/arch/ia64/kernel/irq_ia64.c
> @@ -30,6 +30,9 @@
> #include <linux/threads.h>
> #include <linux/bitops.h>
> #include <linux/irq.h>
> +#ifdef CONFIG_XEN
> +#include <linux/cpu.h>
> +#endif
>
> #include <asm/delay.h>
> #include <asm/intrinsics.h>
> @@ -204,6 +207,13 @@ assign_irq_vector (int irq)
>
> vector = -ENOSPC;
>
> +#ifdef CONFIG_XEN
> + if (is_running_on_xen()) {
> + extern int xen_assign_irq_vector(int);
> + return xen_assign_irq_vector(irq);
> + }
> +#endif
>
No extern prototypes in .c files; definitely not nested in block scope
(here and elsewhere in the series).
> +static char timer_name[NR_CPUS][15];
> +static char ipi_name[NR_CPUS][15];
> +static char resched_name[NR_CPUS][15];
> +static char cmc_name[NR_CPUS][15];
> +static char cmcp_name[NR_CPUS][15];
> +static char cpep_name[NR_CPUS][15];
Why not use percpu?
> +/* FIXME: There's no obvious point to check whether slab is ready. So
> + * a hack is used here by utilizing a late time hook.
> + */
Could you hook onto paravirt_post_allocator_init()?
J
next reply other threads:[~2008-02-21 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 23:22 Jeremy Fitzhardinge [this message]
2008-02-22 5:10 ` [PATCH 19/28] ia64/xen: xen domU irq chip introducing some helper functions, xen_send_ipi Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BE07CE.5090008@goop.org \
--to=jeremy@goop.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox